fix(web): install button and confirmation dialog fixes #1717
Conversation
Since it does not make sense to render the InstallButton when the installation is in progress or finished. The same apply for the login screen, product selection, and product progress.
Changing the default focus in the confirmation dialog from 'Continue' to
'Cancel' to avoid the user triggering the installation because
accidentally sending the {enter} keystroke.
dgdavid
changed the title
To avoid circular dependencies.
| @@ -48,7 +63,7 @@ according to the provided installation settings.", | |||
| {/* TRANSLATORS: button label */} | |||
| {_("Continue")} | |||
| </Popup.Confirm> | |||
| <Popup.Cancel onClick={onClose}> | |||
| <Popup.Cancel autoFocus onClick={onClose}> | |||
There was a problem hiding this comment.
NOTE: I'm aware of https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autofocus#accessibility_concerns but I have slightly tested it with Orca screen reader and it seems to work as expected. No tools for recording it at this moment, sorry.
In any case, let's think on this a as hotfix for preventing users starting the installation by accident and improve it later when re-working the confirmation dialog (https://trello.com/c/SKhWWsAk - private link)
There was a problem hiding this comment.
In any case, let's think on this a as hotfix for preventing users starting the installation by accident and improve it later when re-working the confirmation dialog (https://trello.com/c/SKhWWsAk - private link)
Or evaluate if it has more advantages to relay in the Modal#elementToFocus prop, which was added more than a year ago but I haven't been aware until today while checking the recently released PatternFly v6.
But please let's postpone such an evaluation to the moment we migrate to v6 and apply the decided approach to all dialogs needing to force the focus.
Problems
The "Install" button is shown during the installation progress 😥
Thanks @imobachgs!
The install confirmation dialog could be accepted by mistake because of 'Continue' button receiving the focus by default
https://trello.com/c/8ZWINXjs (internal/private link)
Solutions
autoFocusprop)Testing
Notes
Constants for router paths were moved to a single routes/paths file in order to avoid circular dependencies that made test suite fail after fe18300